Skip to content

Ux polish before launch

Placeholder Sarah Rudderrequested to merge
ux-polish-before-launch into main

Changes proposed in this pull request:

  • Removes Pages and Dashboard menu items from the top bar. "Dashboard" isn't yet decided as a name, and the icon was placeholder; also we aren't ready to crosslink with the Pages app header.

  • Shows an error message so that the homepage isn't empty if you aren't an org manager (I'm not sure why we intended non-managers to not see the user list, while they can still visit that route, but i've addressed that in the next bullet, somewhat):

    Manager:

    before-manager

    Non-manager before:

    before-not-manger

    Non-manger after:

    after-not-manager

  • if you do not have the right to add/remove users from the org (by being an org manager), now you don't see the Add User or Remove buttons, and you see a notice letting you now that you can't change any details on the users list page. (Should we hide "edit permissions" too?):

    Can't edit (non manager)

    does-not-have-access

    Can edit (manager)

    have-access

  • added tests and updated controllers as needed

Submitter checklist

  • [x ] Added logging is not capturing sensitive data and is set to an appropriate level (DEBUG vs INFO etc)
  • [x ] Updated relevant documentation (README, ADRs, explainers, diagrams)

Security considerations

  • This doesn't change what the responses provide, so a user can still see who else is in their org. they just no longer see buttons that even if they clicked on, would error out.

Merge request reports